Avoid having every access of Bounds or Frame allocate a new Rect #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
legacy-area-perf
PureWeen
reviewed
May 11, 2022
PureWeen
approved these changes
May 11, 2022
rmarinho
approved these changes
May 12, 2022
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Every access of Frame (or Bounds) in VisualElement was creating a new Rect by accessing four BindableProperties, which is not ideal from a performance perspective.
These changes track the Frame/Bounds Rect locally, and consolidate the updating of the X/Y/Width/Height bindable properties in one method.